Gossipsub fanout correction #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Convenience link to the upstream diff: https://github.com/sigp/rust-libp2p/compare/b96b90894faab0a1eed78e1c82c6452138a3538a..cfa3275ca17e502799ed56e555b6c0611752e369
LGTM
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
* Correct fanout in gossipsub * Upgrade discv5 to pin new libp2p version * Update cargo.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fanout mapping in gossipsub could be become desychronized causing unexpected errors.
Although these errors in the current revision are being ignored, this prevents invalid states from occurring in the first place.