Prevent rolling file appender panic #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
approved these changes
Jan 23, 2024
danielramirezch
pushed a commit
to danielramirezch/lighthouse
that referenced
this pull request
Feb 14, 2024
* rolling file appender panic removal and max log file count * max log file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5116
Proposed Changes
tracing_appender::rolling::dailycan cause panics. This PR uses theRollingFIleAppender:Builder()instead, which returns aResultand allows us to gracefully handle errors.On a separate note, while playing around with the builder, I noticed a
max_log_fileoptionhttps://docs.rs/tracing-appender/latest/tracing_appender/rolling/struct.Builder.html#method.max_log_files
This allowed me to delete the
cleanup_logging_taskwhich should simplify things a bitAdditional notes
This still doesn't resolve the underlying issue in #5116, it just prevents the panic