Fix off-by-one in backfill sig verification #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
bug
dapplion
approved these changes
Jan 29, 2024
|
|
||
| // If we've reached genesis, add the genesis block root to the batch for all slots | ||
| // between 0 and the first block slot, and set the anchor slot to 0 to indicate | ||
| // completion. | ||
| if expected_block_root == self.genesis_block_root { | ||
| let genesis_slot = self.spec.genesis_slot; | ||
| for slot in genesis_slot.as_usize()..block.slot().as_usize() { | ||
| for slot in genesis_slot.as_usize()..prev_block_slot.as_usize() { |
There was a problem hiding this comment.
Ok, prev_block_slot case is already covered in the previous iteration in lines
lighthouse/beacon_node/beacon_chain/src/historical_blocks.rs
Lines 131 to 134 in 0aa5ed2
michaelsproul
added
ready-for-merge
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6f3af67 |
This was referenced Jan 29, 2024
merge queue: embarking unstable (c7e5dd1) and [#5103 + #5135 + #5120 + #5065 + #5018] together
#5139
Closed
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
* Fix off-by-one in backfill sig verification * Add self-referential PR link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix a bug whereby the signature of the very first block in the chain (e.g. slot 1) would not be verified while backfilling. This was due to the
breakthat occurs upon reaching the anchor bypassing thesigned_blocks.push(signed_block).Proposed Changes
pushbefore thebreakso that all blocks are added tosigned_blocksand subsequently checked.Additional Info
This bug was introduced in Deneb and does not impact v4.5.0. It does impact v4.6.0-rc.0.