Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spell check and update Lighthouse book #6627

Merged
merged 19 commits into from
Dec 17, 2024
Merged

Add spell check and update Lighthouse book #6627

merged 19 commits into from
Dec 17, 2024

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Nov 28, 2024 •
edited
Loading

Issue Addressed

N/A

Proposed Changes

Add spell check to the CI for: Lighthouse book, local testnet documentation, README.md, CONTRIBUTING.md and SECURITY.md

Update Lighthouse book on:
-the database API response to correspond to the latest tree-states format in this commit 9d7ceb5
-delete previous_epoch_active_gwei as it was no longer in the code. Relevant discussion on DIscord: https://discord.com/channels/605577013327167508/605577013331361793/1314325672226979891 in this commit 367f2b1

Additional Info

N/A

@chong-he chong-he added docs Documentation infra-ci labels Nov 28, 2024
@chong-he chong-he requested a review from dapplion November 28, 2024 01:56
@chong-he chong-he added the ready-for-review The code is ready for review label Nov 28, 2024
@michaelsproul michaelsproul added the v6.1.0 New release c. Q1 2025 label Dec 2, 2024
@michaelsproul michaelsproul mentioned this pull request Dec 2, 2024
Closed
@chong-he chong-he changed the title Add spell check to Lighthouse book Add spell check and update Lighthouse book Dec 3, 2024
@michaelsproul michaelsproul mentioned this pull request Dec 17, 2024
Closed
michaelsproul
michaelsproul approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks CK!

book/src/advanced_database.md Outdated Show resolved Hide resolved
book/src/ui-installation.md Outdated Show resolved Hide resolved
@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Dec 17, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1de4983

mergify bot added a commit that referenced this pull request Dec 17, 2024
@mergify
Merge of #6627
8f2dfa2
@mergify mergify bot mentioned this pull request Dec 17, 2024
Closed
5 tasks
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 17, 2024
@mergify mergify bot merged commit 1de4983 into sigp:unstable Dec 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@dapplion dapplion Awaiting requested review from dapplion

Assignees
No one assigned
Labels
docs Documentation infra-ci ready-for-merge This PR is ready to merge. v6.1.0 New release c. Q1 2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chong-he @michaelsproul