Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kurtosis, web3signer and cargo-audit for CI #6671

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Dec 9, 2024

Issue Addressed

Fix the failing Kurtosis jobs on CI, e.g.

https://github.com/sigp/lighthouse/actions/runs/12226785831/job/34102825704?pr=6669

Proposed Changes

  • Kurtosis fix: Remove the -0 that was being erroneously added to the artifact name reference in the doppelganger script. Something must have changed upstream to break this.
  • Web3signer fix: update to Java 21.
  • Cargo audit: temporarily ignore vuln for idna until upstream patch is available.
  • May-as-well: install the latest version of kurtosis-cli, rather than pinning 1.3.1.

@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress infra-ci v6.0.1 Bugfix for v6.0.0 labels Dec 9, 2024
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Dec 9, 2024
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 9, 2024
@jimmygchen
Copy link
Member

jimmygchen commented Dec 9, 2024

There's a breaking change in the new version of Web3Signer - it now requires Java 21 runtime. Created a PR to test the fix:
#6674

@michaelsproul michaelsproul changed the title Fix Kurtosis tests on CI Fix Kurtosis, web3signer and cargo-audit for CI Dec 10, 2024
@michaelsproul
Copy link
Member Author

Just the flaky network tests failing now. I'll try a merge

@michaelsproul
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Dec 10, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link

mergify bot commented Dec 10, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@michaelsproul
Copy link
Member Author

@mergify requeue

Copy link

mergify bot commented Dec 10, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Dec 10, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link

mergify bot commented Dec 10, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Dec 10, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Dec 10, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e9ec67e

@mergify mergify bot merged commit e9ec67e into sigp:release-v6.0.1 Dec 10, 2024
29 checks passed
@michaelsproul michaelsproul deleted the fix-kurtosis branch December 10, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci ready-for-merge This PR is ready to merge. v6.0.1 Bugfix for v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants