Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PeerDAS subnet decoupling (aka custody groups) #6736

Draft
wants to merge 4 commits into
base: unstable
Choose a base branch
from

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Dec 20, 2024

Issue Addressed

#6709

Spec: ethereum/consensus-specs#3832

Proposed Changes:

On startup, we construct NetworkGlobals and compute sampling subnets and sampling columns from NodeId - this remains the same but the computation logic has been updated to compute these from custody groups. (node_id => custody_groups => subnets and columns)

  • Introduce "custody groups" and compute custody subnets and columns with custody group.
  • Change custody_subnet_count (csc) to custody_group_count (cgc) in MetaData and ENR. (spec)
  • Add a custody group to subnet mapping in PeerManager to avoid re-computing it when setting peer subnets based on their custody groups.
  • The sampling_size computation logic is has been updated to be base on custody groups instead of custody subnets. code (spec update)
  • Refactored sampling_size and custody_group_count logic into ChainSpec to keep them in one place.

@jimmygchen jimmygchen changed the title Implement PeerDAS subnet decoupling (aka custody groups). Implement PeerDAS subnet decoupling (aka custody groups) Dec 20, 2024
@jimmygchen jimmygchen added das Data Availability Sampling work-in-progress PR is a work-in-progress labels Dec 20, 2024
Squashed commit of the following:

commit 898d05e
Merge: ffbd25e 7e0cdde
Author: Jimmy Chen <jchen.tc@gmail.com>
Date:   Tue Dec 24 14:41:19 2024 +1100

    Merge branch 'unstable' into refactor-ef-tests-features

commit ffbd25e
Author: Jimmy Chen <jchen.tc@gmail.com>
Date:   Tue Dec 24 14:40:38 2024 +1100

    Fix `SszStatic` tests for PeerDAS: exclude eip7594 test vectors when testing Electra types.

commit aa593cf
Author: Jimmy Chen <jchen.tc@gmail.com>
Date:   Fri Dec 20 12:08:54 2024 +1100

    Refactor spec testing for features and simplify usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling work-in-progress PR is a work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant