Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing crates to cargo workspace #6774

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

macladson
Copy link
Member

Issue Addressed

@chong-he noticed that some crates were not having their Cargo.toml files automatically ordered by cargo sort --workspace and opened PR #6758
Turns out that certain crates were not added as members to the Lighthouse workspace.

Proposed Changes

I've now added these crates to the workspace and run cargo sort --workspace again.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 9, 2025
@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jan 10, 2025

queue

🛑 The pull request has been removed from the queue default

Pull request #6774 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@mergify dequeue

Copy link

mergify bot commented Jan 10, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6774 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link

mergify bot commented Jan 10, 2025

dequeue

✅ The pull request has been removed from the queue default

@michaelsproul
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jan 10, 2025

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jan 10, 2025

queue

🛑 The pull request has been removed from the queue default

Pull request #6774 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jan 10, 2025
mergify bot added a commit that referenced this pull request Jan 10, 2025
mergify bot added a commit that referenced this pull request Jan 10, 2025
@michaelsproul
Copy link
Member

@mergify dequeue

Copy link

mergify bot commented Jan 10, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6774 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link

mergify bot commented Jan 10, 2025

dequeue

✅ The pull request has been removed from the queue default

@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jan 10, 2025

queue

🛑 The pull request has been removed from the queue default

Pull request #6774 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jan 10, 2025

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jan 10, 2025

queue

🛑 The pull request has been removed from the queue default

Pull request #6774 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jan 10, 2025
@jimmygchen
Copy link
Member

Dequeuing this early since CI has already failed and it won't merge.

@jimmygchen
Copy link
Member

@mergify dequeue

Copy link

mergify bot commented Jan 10, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #6774 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link

mergify bot commented Jan 10, 2025

dequeue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

Will try to instamerge #6329 once CI completes and requeue this one.

@jimmygchen
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jan 10, 2025

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link

mergify bot commented Jan 10, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jan 10, 2025

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jan 10, 2025

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link

mergify bot commented Jan 10, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jan 10, 2025

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jan 10, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 348fbdb

@mergify mergify bot merged commit 348fbdb into sigp:unstable Jan 10, 2025
30 checks passed
@macladson macladson deleted the add-remaining-crates-workspace branch January 12, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants