Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gossipsub): remove control pool #559

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

jxs
Copy link
Member

@jxs jxs commented Dec 5, 2023

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

jxs added 4 commits December 4, 2023 14:51
which will help for the goal of prioritizing GRAFT and PRUNE messages over IWANT/IHAVE.
when subscribing a topic, instead of doing it in the next heartbeat via control pool.
instead of doing it in the next heartbeat via control pool.
@jxs jxs marked this pull request as draft December 5, 2023 19:37
jxs added 3 commits December 5, 2023 22:52
tests are changed due to how count_control_messages work. Previously when counting messages they
were consumed from the source: control_pool and the NetworkBehaviour events list, with the
new channels, to read a message one has to consume it, that's why test numbers were changed.
@jxs jxs force-pushed the remove-control-pool-sigp branch from c8f248b to 8dd0639 Compare December 5, 2023 22:53
@jxs jxs changed the title Remove control pool sigp feat(gossipsub): remove control pool Dec 5, 2023
@AgeManning AgeManning marked this pull request as ready for review December 6, 2023 04:56
@AgeManning AgeManning merged commit 8a350f5 into sigp:lighthouse-gossipsub Dec 6, 2023
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants