Skip to content

Commit

Permalink
bump up to 18 node version
Browse files Browse the repository at this point in the history
  • Loading branch information
rickimoore committed Feb 27, 2023
1 parent 73fb7fc commit 74eb2ee
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ jobs:
steps:
- name: Checkout sources
uses: actions/checkout@v3
- name: Use node 16
- name: Use node 18
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

# ==============================
# Linux dependencies
Expand All @@ -61,7 +61,7 @@ jobs:
# ==============================
# Builds
# ==============================
- name: Build Siren
- name: Build Siren
run: make release

- name: Configure GPG and create artifacts
Expand Down
21 changes: 21 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
ARG node_version=18
ARG node_image=node:${node_version}

# STAGE 1: builder
FROM $node_image AS builder

COPY . /app/
WORKDIR /app

ENV NODE_ENV=development
# install (dev) deps
RUN yarn

ENV NODE_ENV=production
# build (prod) app
RUN yarn build

# STAGE 2
FROM nginx:alpine AS production

COPY --from=builder /app/build/ /usr/share/nginx/html/
12 changes: 12 additions & 0 deletions Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
ARG node_version=18
ARG node_image=node:${node_version}
FROM $node_image

ENV NODE_ENV=development

EXPOSE 5000/tcp
COPY . /app/
WORKDIR /app

RUN yarn install
CMD ["yarn", "run", "dev"]

0 comments on commit 74eb2ee

Please sign in to comment.