-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start publishing the cursed token on GitHub Pages #7
Start publishing the cursed token on GitHub Pages #7
Conversation
* This should makes it a lot easier to find, download and use * The old upload is preserved so old scripts should keep working As a result the latest token should always be available in https://sigstore-conformance.github.io/extremely-dangerous-public-oidc-beacon/oidc-token.txt Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
I suppose we should wait until there's a sigstore-conformance release and until the known users have upgraded as well. |
note to self: All conformance users have now upgraded (or are using main branch). |
This bit in sigstore-conformance I'm not sure about:
Does the workflow id stay the same? I expect that it does but I can't be sure. |
I think it does, but we can confirm/update with https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#get-a-workflow if it breaks after merging 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'd like @tetsuo-cpp or @tnytown to also take a brief look at this if either have time 🙂
In my experience, GitHub Pages sometimes takes a bit to propagate changes due to caching -- is this a concern w.r.t. the tokens, given their relatively short validity period? Implementation LGTM! |
Caching on the HTTP header side, or caching on the deployment side? I wouldn't be surprised if GHP serves HTTP caching headers, but we can always ignore those 🙂 |
IIRC the deployment side, it's been a while since I've had to worry about it. I've never experienced a delay of more than 5 minutes, but that may still impact the validity period of the tokens if the behavior is still present :( |
Gotcha. I think we can go ahead and deploy this as-is; if we run into consistent issues, then we'll look into another publication mechanism or location. |
Appears to be working: https://sigstore-conformance.github.io/extremely-dangerous-public-oidc-beacon/oidc-token.txt |
Start publishing the token on GitHub Pages (https://sigstore-conformance.github.io/extremely-dangerous-public-oidc-beacon/oidc-token.txt):
Fixes #5.
Details: