added unit tests and removed log entry

Signed-off-by: Tobias Trabelsi <tobias.trabelsi@dbschenker.com>

pkg/oci/mutate/signatures.go

@@ -16,7 +16,6 @@
 package mutate
 
 import (
-	"log"
 	"time"
 
 	v1 "github.com/google/go-containerregistry/pkg/v1"
@@ -42,13 +41,8 @@ func AppendSignatures(base oci.Signatures, sigs ...oci.Signature) (oci.Signature
 
 	img, err := mutate.Append(base, adds...)
 
-	imgCfg, _ := img.ConfigFile()
-
 	// Set the Created date to time of execution
-	if imgCfg.Created.Time.IsZero() {
-		log.Println("Signed Entry Date was Zero, Setting to current time")
-		img, _ = mutate.CreatedAt(img, v1.Time{Time: time.Now()})
-	}
+	img, _ = mutate.CreatedAt(img, v1.Time{Time: time.Now()})
 
 	if err != nil {
 		return nil, err

pkg/oci/mutate/signatures_test.go

@@ -17,6 +17,7 @@ package mutate
 
 import (
 	"testing"
+	"time"
 
 	"github.com/sigstore/cosign/pkg/oci/empty"
 	"github.com/sigstore/cosign/pkg/oci/static"
@@ -70,4 +71,9 @@ func TestAppendSignatures(t *testing.T) {
 	} else if got, want := len(sl), 3; got != want {
 		t.Errorf("len(Get()) = %d, wanted %d", got, want)
 	}
+
+	testCfg, _ := threeSig.ConfigFile()
+	if testCfg.Created.Time.IsZero() {
+		t.Errorf("Date of Signature was Zero. Should be %s", time.Now())
+	}
 }

pkg/oci/static/file.go

@@ -17,7 +17,6 @@ package static
 
 import (
 	"io"
-	"log"
 	"time"
 
 	v1 "github.com/google/go-containerregistry/pkg/v1"
@@ -44,13 +43,8 @@ func NewFile(payload []byte, opts ...Option) (oci.File, error) {
 		Layer: layer,
 	})
 
-	imgCfg, _ := img.ConfigFile()
-
 	// Set the Created date to time of execution
-	if imgCfg.Created.Time.IsZero() {
-		log.Println("Signed Entry Date was Zero, Setting to current time")
-		img, err = mutate.CreatedAt(img, v1.Time{Time: time.Now()})
-	}
+	img, err = mutate.CreatedAt(img, v1.Time{Time: time.Now()})
 
 	if err != nil {
 		return nil, err

pkg/oci/static/file_test.go

@@ -120,4 +120,14 @@ func TestNewFile(t *testing.T) {
 			t.Errorf("Payload() = %s, wanted %s", got, want)
 		}
 	})
+
+	t.Run("check date", func(t *testing.T) {
+		fileCfg, err := file.ConfigFile()
+		if err != nil {
+			t.Fatalf("FileCfg() = %v", err)
+		}
+		if fileCfg.Created.Time.IsZero() {
+			t.Errorf("Date of Signature was Zero")
+		}
+	})
 }