Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: treat 403 as non-fatal when checking for manifests #2972

Closed
wants to merge 1 commit into from

Commits on May 12, 2023

  1. treat 403 as non-fatal when checking for manifests

    Some Docker registries (ex.JFrog Artifactory) return
    403 instead of 404 for a non-existent tag if that tag
    starts with 'sha256' - which results in a fatal error
    and inability to use `cosign sign`.
    This change treats 403 the same way as 404 to overcome this.
    
    It is similar and related to
    google/go-containerregistry#1691
    "Make 403 non-fatal for manifest existence checks".
    
    Closes sigstore#2973.
    
    Signed-off-by: Dmitry S <dsavints@gmail.com>
    dmitris committed May 12, 2023
    Configuration menu
    Copy the full SHA
    3d8cf65 View commit details
    Browse the repository at this point in the history