Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated in_toto.ProvenanceStatement #3243

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Sep 15, 2023

Summary

The struct in_toto.ProvenanceStatement is marked as deprecated. Instead, it is recommened to use a version-specific struct. The in_toto.ProvenanceStatementSLSA02 is the equivalent.

Release Note

  • When generating a SLSA v0.2 statement, attestation.GenerateStatement now returns an object of type in_toto.ProvenanceStatementSLSA02 instead of the deprecated in_toto.ProvenanceStatement.

Documentation

NONE

The struct `in_toto.ProvenanceStatement` is marked as deprecated.
Instead, it is recommened to use a version-specific struct. The
`in_toto.ProvenanceStatementSLSA02` is the equivalent.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #3243 (5e4624c) into main (ee66f35) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3243   +/-   ##
=======================================
  Coverage   30.37%   30.37%           
=======================================
  Files         155      155           
  Lines        9835     9835           
=======================================
  Hits         2987     2987           
  Misses       6402     6402           
  Partials      446      446           
Files Changed Coverage Δ
pkg/policy/attestation.go 31.57% <0.00%> (ø)

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haydentherapper haydentherapper merged commit 44f7703 into sigstore:main Sep 18, 2023
28 checks passed
@github-actions github-actions bot added this to the v2.3.0 milestone Sep 18, 2023
@lcarva lcarva deleted the use-provenance-stmt-02 branch September 18, 2023 17:17
lance pushed a commit to securesign/cosign that referenced this pull request Sep 25, 2023
The struct `in_toto.ProvenanceStatement` is marked as deprecated.
Instead, it is recommened to use a version-specific struct. The
`in_toto.ProvenanceStatementSLSA02` is the equivalent.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@cpanato cpanato modified the milestones: v2.3.0, v2.2.1 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants