feat: add --only flag in cosign copy to copy sign, att & sbom
#3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3247 +/- ##
==========================================
+ Coverage 30.35% 30.77% +0.42%
==========================================
Files 155 155
Lines 9845 9949 +104
==========================================
+ Hits 2988 3062 +74
- Misses 6410 6431 +21
- Partials 447 456 +9
|
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
haydentherapper
requested changes
Oct 17, 2023
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
|
@haydentherapper Fixed, can you please re-review |
cmd/cosign/cli/copy/copy.go
Outdated
| @@ -175,12 +174,13 @@ func remoteCopy(ctx context.Context, pusher *remote.Pusher, src, dest name.Refer | |||
| return pusher.Push(ctx, dest, got) | |||
| } | |||
|
|
|||
| func parseOnlyFlag(str string, sigOnly bool) []tagMap { | |||
| func parseeOnlyOpt(str string, sigOnly bool) []tagMap { | |||
There was a problem hiding this comment.
spelling "parseOnlyOpt"
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
haydentherapper
approved these changes
Oct 17, 2023
|
@haydentherapper fixed |
haydentherapper
added a commit
to haydentherapper/cosign
that referenced
this pull request
Dec 4, 2023
PR sigstore#3247 added an --only flag which when set copies only a subset of metadata. By default the flag is set to an empty string, meaning that by default copy would copy nothing. This PR fixes this bug so that if only is unset, copy defaults to the same behavior as before copying everything. Also update the tag name to be sig rather than sign for the flag. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
hectorj2f
pushed a commit
that referenced
this pull request
Dec 5, 2023
PR #3247 added an --only flag which when set copies only a subset of metadata. By default the flag is set to an empty string, meaning that by default copy would copy nothing. This PR fixes this bug so that if only is unset, copy defaults to the same behavior as before copying everything. Also update the tag name to be sig rather than sign for the flag. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #2002
This PR will add a new
--onlyflag that accept custom string array to download sboms, signatures and attestationsRelease Note
Added
--onlyflag incosign copyto copy sign, att & sbomDocumentation
Ran
make docgento generate required docs