feat: improve dockerfile verify subcommand #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobyMCbobs
force-pushed
the
improve-dockerfile-verify
branch
2 times, most recently
from
443ba73
to
e6eadee
Compare
Codecov Report
@@ Coverage Diff @@
## main #3264 +/- ##
==========================================
+ Coverage 30.32% 30.67% +0.35%
==========================================
Files 155 155
Lines 9853 9923 +70
==========================================
+ Hits 2988 3044 +56
- Misses 6418 6429 +11
- Partials 447 450 +3
|
BobyMCbobs
force-pushed
the
improve-dockerfile-verify
branch
3 times, most recently
from
dc68327
to
58b51bd
Compare
cpanato
requested changes
Oct 5, 2023
| { | ||
| name: "gauntlet", | ||
| fileContents: `FROM gcr.io/${TEST_IMAGE_REPO_PATH}/one AS one | ||
| RUN script1 | ||
| FROM gcr.io/$TEST_IMAGE_REPO_PATH/${TEST_SUBREPO}:latest | ||
| RUN script2 | ||
| FROM --platform=linux/amd64 gcr.io/${TEST_IMAGE_REPO_PATH}/$TEST_RUNTIME_SUBREPO | ||
| COPY --from=gcr.io/someorg/someimage /etc/config /app/etc/config |
There was a problem hiding this comment.
This looks a bit off, can you check the indentation?
support images resolved from ENV, ARG and COPY --from Signed-off-by: Caleb Woodbine <calebwoodbine.public@gmail.com>
BobyMCbobs
force-pushed
the
improve-dockerfile-verify
branch
from
58b51bd
to
76858d7
Compare
haydentherapper
approved these changes
Oct 16, 2023
haydentherapper
approved these changes
Oct 16, 2023
|
Wooohoooo! Thank you for the merge @haydentherapper @hectorj2f @cpanato! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support images resolved from ENV, ARG and COPY --from
resolves: #3260
Summary
cosign dockerfile verifydoes not interpolate variables inFROMstatements, instead just panics.Adds the ability to load key-value pairs from
ENVandARGto interpolate inFROMandCOPY --fromstatements.Release Note
Improved discoverability for images in Dockerfiles