Support ReplaceOp in Signatures #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, calling WithReplaceOp didn't do anything for signatures and only affected attestations. I believe this is because the implementation of Dedupe and Replace was copied to 6 different methods, so they weren't getting updated. I've extracted the core of the impl into a dedupeAndReplace method on opts, which makes each impl just a one line call with either signatures or attestations passed in. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #3315 +/- ##
==========================================
- Coverage 30.65% 30.31% -0.35%
==========================================
Files 155 155
Lines 9994 9919 -75
==========================================
- Hits 3064 3007 -57
+ Misses 6474 6462 -12
+ Partials 456 450 -6
|
mattmoor
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, calling WithReplaceOp didn't do anything for signatures and only affected attestations. I believe this is because the implementation of Dedupe and Replace was copied to 6 different methods, so they weren't getting updated.
I've extracted the core of the impl into a dedupeAndReplace method on opts, which makes each impl just a one line call with either signatures or attestations passed in.