Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use go1.22.7 and golangci-lint #3864

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 6, 2024

  • update to use go1.22.7
  • update golangci-lint to v1.60

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.69%. Comparing base (2ef6022) to head (89ecc56).
Report is 212 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/templates/help_flags_printer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3864      +/-   ##
==========================================
- Coverage   40.10%   36.69%   -3.41%     
==========================================
  Files         155      203      +48     
  Lines       10044    12780    +2736     
==========================================
+ Hits         4028     4690     +662     
- Misses       5530     7507    +1977     
- Partials      486      583      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hectorj2f
hectorj2f previously approved these changes Sep 8, 2024
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, thanks @cpanato

@cpanato cpanato enabled auto-merge (squash) September 10, 2024 16:33
@cpanato cpanato merged commit 4ffbf5f into sigstore:main Sep 10, 2024
23 checks passed
@cpanato cpanato deleted the update-go1227 branch September 10, 2024 16:39
dmitris pushed a commit to dmitris/cosign that referenced this pull request Oct 17, 2024
* update to use go1.22.7

Signed-off-by: cpanato <ctadeu@gmail.com>

* update golangci-lint to v1.60

Signed-off-by: cpanato <ctadeu@gmail.com>

* fix lints

Signed-off-by: cpanato <ctadeu@gmail.com>

* update chainguard-dev/actions/kind-diag

Signed-off-by: cpanato <ctadeu@gmail.com>

---------

Signed-off-by: cpanato <ctadeu@gmail.com>
kipz pushed a commit to kipz/cosign that referenced this pull request Oct 21, 2024
* update to use go1.22.7

Signed-off-by: cpanato <ctadeu@gmail.com>

* update golangci-lint to v1.60

Signed-off-by: cpanato <ctadeu@gmail.com>

* fix lints

Signed-off-by: cpanato <ctadeu@gmail.com>

* update chainguard-dev/actions/kind-diag

Signed-off-by: cpanato <ctadeu@gmail.com>

---------

Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants