Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates KMS support docs #125

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

ChrisJBurns
Copy link
Contributor

@ChrisJBurns ChrisJBurns commented Apr 12, 2023

  • updates and migrates KMS support docs as part of documentation migration Migrate documentation to docs.sigstore.dev cosign#822
  • corrects reference to dlorenc images and replaces with generic user
  • improves readability for some code snippets
  • adds mention for Azure Key Vault and Kubernetes Secrets

This aims to deprecate https://github.com/sigstore/cosign/blob/main/KMS.md

Signed-off-by: ChrisJBurns 29541485+ChrisJBurns@users.noreply.github.com

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 6699b5b
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/64371a0ebf1d520009ca3f50
😎 Deploy Preview https://deploy-preview-125--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ChrisJBurns
Copy link
Contributor Author

@ltagliaferri Here is the KMS one for whenever you have some time :) I've pretty much just copied and pasted the one from sigstore/KMS.md and just improved some formatting to make the page a bit more readable.

Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ltagliaferri ltagliaferri merged commit 7d3855f into sigstore:main Apr 13, 2023
@ChrisJBurns ChrisJBurns deleted the migrates-kms-docs branch April 13, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants