Check nil key shouldn't validate signature

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
sigstore · May 13, 2022 · 76edd42 · 76edd42
1 parent 20db4b0
commit 76edd42
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/challenges/challenges_test.go b/pkg/challenges/challenges_test.go
@@ -580,6 +580,11 @@ func TestCheckSignatureECDSA(t *testing.T) {
 		t.Fatal(err)
 	}
 
+	// Nil key should fail
+	if err := CheckSignature(nil, signature, email); err == nil {
+		t.Error("nil public key should raise error")
+	}
+
 	// Try a bad email but "good" signature
 	if err := CheckSignature(&priv.PublicKey, signature, "bad@email.com"); err == nil {
 		t.Fatal("check should have failed")