Add chain in response for all CAs, fix newlines in response #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The certificate's chain was not being included when issuing certificates for non-GCP CAs. We were also adding too many newlines between PEM-encoded certificates. pem.Encode automatically adds newlines. Just in case the source that's providing the certificates is not including trailing newlines, I've added a check to optionally append newlines. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
dlorenc
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The certificate's chain was not being included when issuing
certificates for non-GCP CAs.
We were also adding too many newlines between PEM-encoded
certificates. pem.Encode automatically adds newlines. Just
in case the source that's providing the certificates is
not including trailing newlines, I've added a check to
optionally append newlines. The
dev.sigstore.cosign/chainannotation will no longer start with a newline after this change.
I've tested these changes with a local instance of Fulcio, and
there were no issues with Cosign signing and verifying.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note