Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Require inclusion proofs #82

Closed
haydentherapper opened this issue Jun 29, 2023 · 1 comment · Fixed by #84
Closed

[Proposal] Require inclusion proofs #82

haydentherapper opened this issue Jun 29, 2023 · 1 comment · Fixed by #84

Comments

@haydentherapper
Copy link
Collaborator

haydentherapper commented Jun 29, 2023 •
edited
Loading

As discussed in sigstore/rekor#1566, I am proposing that inclusion proofs in bundles become mandatory. There are no server-side changes, as these are already returned.

Here's a table of the current support for inclusion proofs per client, and how they support verifying proofs (included SETs to be thorough).

Client Proof included in bundle? Verifying Proofs Offline Verifying Proofs Online Verifying SETs
sigstore-java Yes Yes? Yes? Yes
sigstore-js WIP No No Yes
sigstore-python Yes Yes Yes Yes
cosign No, no bundle support Yes (not from bundle) Yes Yes (not from bundle)
sigstore-rs No, no bundle support No No Yes?

@bdehamer @woodruffw @loosebazooka @znewman01 Please let me know if anything is inaccurate or help fill in the question marks.
@woodruffw
Copy link
Member

sigstore-python supports both online and offline proof verification, so I think that should be a yes 🙂

@bdehamer bdehamer mentioned this issue Jun 30, 2023
Merged
haydentherapper added a commit to haydentherapper/protobuf-specs that referenced this issue Jun 30, 2023
@haydentherapper
Require inclusion proofs, make promises optional
c18c1e9 
The log always generates inclusion proofs, so we will make it a
requirement that clients verify the proof. Promises will be deprecated
over time, but for now, we'll make them optional.

Fixes sigstore#82
Ref sigstore/rekor#1566

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper mentioned this issue Jun 30, 2023
Merged
kommendorkapten pushed a commit that referenced this issue Jul 3, 2023
@haydentherapper
Require inclusion proofs, make promises optional (#84)
b532639 
* Require inclusion proofs, make promises optional

The log always generates inclusion proofs, so we will make it a
requirement that clients verify the proof. Promises will be deprecated
over time, but for now, we'll make them optional.

Fixes #82
Ref sigstore/rekor#1566

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Bump version

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Update client verification requirements for promises

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

---------

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@woodruffw woodruffw mentioned this issue Jul 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require inclusion proofs, make promises optional haydentherapper/protobuf-specs
2 participants
@woodruffw @haydentherapper