Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address zizmor issues, remove 3p action for creating release for java #494

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

bobcallaway
Copy link
Member

This fixes issues reported by zizmor 🌈, as well as removing a dependency on a third-party action when the gh CLI should work just fine.

This also moves the gradle wrapper validation check to a non-deprecated action.

@loosebazooka @woodruffw fyi

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java stuff looks good to me, ideally next step we add access to a pgp key to do the release to sonatype directly. We already have a java releasers group with permissions to write to the dev.sigstore on maven central

@bobcallaway
Copy link
Member Author

Java stuff looks good to me, ideally next step we add access to a pgp key to do the release to sonatype directly. We already have a java releasers group with permissions to write to the dev.sigstore on maven central

yup, i'll do that in a separate PR

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the zizmor side!

@bobcallaway bobcallaway merged commit c1af8c8 into sigstore:main Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants