Clarified the intent of the listed instances in the trusted_root #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+80
to
+81
| // All the listed instances SHOULD be sorted by the 'valid_for' in ascending | ||
| // order, that is, the oldest instance first and the current instance last. |
There was a problem hiding this comment.
Just curious why this matters?
There was a problem hiding this comment.
From programmatic perspective, it doesn't. But it's always nice to have items ordered when they can, and it makes it easier to inspect/work with the files for humans.
haydentherapper
approved these changes
May 11, 2023
…age. The semantics around valid_for was not properly explained and could lead to confusion. Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@google.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
kommendorkapten
force-pushed
the
clarify_current_instance
branch
from
e67531e to
218d057
Compare
znewman01
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The semantics around valid_for was not properly explained and could lead to confusion.
Release Note
N/A
Documentation
N/A