Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Significant increase in runtime for consistency proof checks #588

Closed
haydentherapper opened this issue Feb 3, 2025 · 1 comment · Fixed by #601
Closed

Significant increase in runtime for consistency proof checks #588

haydentherapper opened this issue Feb 3, 2025 · 1 comment · Fixed by #601
Labels
bug Something isn't working

Comments

@haydentherapper
Copy link
Contributor

Description

Version

Looking at GitHub Actions, the runtime has increased to >5 min when it used to be <30s.
@haydentherapper haydentherapper added the bug Something isn't working label Feb 3, 2025
haydentherapper added a commit to haydentherapper/rekor-monitor that referenced this issue Feb 10, 2025
@haydentherapper
Immediately tick to avoid waiting an interval
72b19f4 
Fixes sigstore#588

With a recent refactor where we added support for catching a signal,
this caused the ticker to wait a full interval before running the
consistency check, which meant that runtime went from immediate to 5 min
by default. This fixes the bug by moving the for-select logic to the end
of the loop, a solution recommended online.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper mentioned this issue Feb 10, 2025
Merged
haydentherapper added a commit that referenced this issue Feb 10, 2025
@haydentherapper
Immediately tick to avoid waiting an interval (#601)
618435f 
Fixes #588

With a recent refactor where we added support for catching a signal,
this caused the ticker to wait a full interval before running the
consistency check, which meant that runtime went from immediate to 5 min
by default. This fixes the bug by moving the for-select logic to the end
of the loop, a solution recommended online.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Contributor Author

Verified - https://github.com/sigstore/rekor-monitor/actions/runs/13252012845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Immediately tick to avoid waiting an interval haydentherapper/rekor-monitor
1 participant
@haydentherapper