enable configurable client retries with backoff in RekorClient #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
bobcallaway
force-pushed
the
client_retries
branch
from
cba5641 to
740de50
Compare
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
+ Coverage 63.68% 63.75% +0.07%
==========================================
Files 82 82
Lines 7559 7574 +15
==========================================
+ Hits 4814 4829 +15
Misses 2119 2119
Partials 626 626
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
priyawadhwa
approved these changes
Oct 5, 2022
asraa
reviewed
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configurable amount of retries for users of RekorClient, as well as the ability to customize the logger. The underlying library (github.com/hashicorp/go-retryablehttp) implements exponential backoff and respects
Retry-Afterresponse headers.I'll push up another PR that changes
rekor-clito take advantage of these changes.Signed-off-by: Bob Callaway bcallaway@google.com