Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharding - Additional tests #1156

Merged

Conversation

naveensrinivasan
Copy link
Contributor

Additional tests for sharding
Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com

@naveensrinivasan naveensrinivasan requested a review from a team as a code owner October 28, 2022 01:40
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/sharding-tests branch from e002433 to 14b043c Compare October 28, 2022 01:44
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #1156 (14b043c) into main (6f7e892) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
+ Coverage   63.98%   64.25%   +0.27%     
==========================================
  Files          82       82              
  Lines        7635     7635              
==========================================
+ Hits         4885     4906      +21     
+ Misses       2119     2100      -19     
+ Partials      631      629       -2     
Flag Coverage Δ
e2etests 48.82% <ø> (ø)
unittests 42.01% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/helm/v0.0.1/entry.go 47.47% <0.00%> (ø)
pkg/types/alpine/v0.0.1/entry.go 73.57% <0.00%> (+1.21%) ⬆️
pkg/sharding/sharding.go 90.51% <0.00%> (+1.72%) ⬆️
pkg/sharding/ranges.go 64.70% <0.00%> (+13.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@naveensrinivasan
Copy link
Contributor Author

Merging #1156 (14b043c) into main (6f7e892) will decrease coverage by 21.96%.

How is this going to make it decrease coverage by 21.96 🤷 ?

@bobcallaway
Copy link
Member

Merging #1156 (14b043c) into main (6f7e892) will decrease coverage by 21.96%.

How is this going to make it decrease coverage by 21.96 shrug ?

it just says that prematurely (until both results are uploaded), this PR does improve coverage (as you can see by the specific file).

@naveensrinivasan
Copy link
Contributor Author

@sigstore/rekor-codeowners a friendly ping

@bobcallaway bobcallaway merged commit 02c00f6 into sigstore:main Nov 1, 2022
@github-actions github-actions bot added this to the v1.1.0 milestone Nov 1, 2022
@naveensrinivasan naveensrinivasan deleted the naveen/feat/sharding-tests branch November 1, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants