Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle invalid or missing pki format #1281

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

bobcallaway
Copy link
Member

Fixes: #1280

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Merging #1281 (5604b35) into main (fd87095) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
- Coverage   63.19%   63.12%   -0.07%     
==========================================
  Files          82       82              
  Lines        7847     7849       +2     
==========================================
- Hits         4959     4955       -4     
- Misses       2258     2262       +4     
- Partials      630      632       +2     
Flag Coverage Δ
e2etests 46.70% <50.00%> (-0.02%) ⬇️
unittests 42.73% <50.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/rekord/v0.0.1/entry.go 66.97% <100.00%> (+0.20%) ⬆️
pkg/types/alpine/v0.0.1/entry.go 71.71% <0.00%> (-2.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@asraa asraa merged commit e512bbe into sigstore:main Jan 17, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Jan 17, 2023
bobcallaway added a commit to bobcallaway/rekor that referenced this pull request Jan 17, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>
bobcallaway added a commit that referenced this pull request Jan 17, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>

Signed-off-by: Bob Callaway <bcallaway@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rekord-type CreateFromArtifactProperties does not handle missing or invalid PKIFormat correctly
4 participants