-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove replace in go.mod #1444
Remove replace in go.mod #1444
Conversation
cc @AdamKorcz - Is this going to break fuzzing? |
Yep, definitely does. Can we upstream those fuzzing changes? |
I could fix it temporarily by doing this in the OSS-Fuzz build script instead, so we perform the replace when OSS-Fuzz builds the fuzzers. I can upstream these changes next week. |
Thanks! |
@AdamKorcz Any progress on upstreaming? |
Bumping again - This is blocking a new release, so I may need to remove fuzzing temporarily. |
Sorry @haydentherapper Line 22 in 4eabf77
|
Will do! Thanks for the pointer. |
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
b455404
to
332a72b
Compare
@AdamKorcz I ended up switching out the dependency to your fork. Otherwise, I'd also need to tag some of the fuzz test files to not always build, and this seemed like an easier approach. |
Codecov Report
@@ Coverage Diff @@
## main #1444 +/- ##
===========================================
+ Coverage 47.68% 64.35% +16.67%
===========================================
Files 82 82
Lines 7873 7873
===========================================
+ Hits 3754 5067 +1313
+ Misses 3415 2159 -1256
+ Partials 704 647 -57
Flags with carried forward coverage won't be shown. Click here to find out more. |
@haydentherapper Awesome, that works fine from the OSS-Fuzz side of things as well. Thanks! |
Fixes #1440
Summary
Release Note
Documentation