Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replace in go.mod #1444

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Remove replace in go.mod #1444

merged 2 commits into from
Apr 28, 2023

Conversation

haydentherapper
Copy link
Contributor

Fixes #1440

Summary

Release Note

Documentation

@haydentherapper haydentherapper requested a review from a team as a code owner April 18, 2023 22:45
@haydentherapper
Copy link
Contributor Author

cc @AdamKorcz - Is this going to break fuzzing?

@haydentherapper
Copy link
Contributor Author

Yep, definitely does. Can we upstream those fuzzing changes?

priyawadhwa
priyawadhwa previously approved these changes Apr 19, 2023
@AdamKorcz
Copy link
Contributor

Yep, definitely does. Can we upstream those fuzzing changes?

I could fix it temporarily by doing this in the OSS-Fuzz build script instead, so we perform the replace when OSS-Fuzz builds the fuzzers. I can upstream these changes next week.

@haydentherapper
Copy link
Contributor Author

Thanks!

@haydentherapper
Copy link
Contributor Author

@AdamKorcz Any progress on upstreaming?

@haydentherapper
Copy link
Contributor Author

Bumping again - This is blocking a new release, so I may need to remove fuzzing temporarily.

@AdamKorcz
Copy link
Contributor

Sorry @haydentherapper
Could you place the same replace right after this line?

cd $SRC/rekor

@haydentherapper
Copy link
Contributor Author

Will do! Thanks for the pointer.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Contributor Author

@AdamKorcz I ended up switching out the dependency to your fork. Otherwise, I'd also need to tag some of the fuzz test files to not always build, and this seemed like an easier approach.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1444 (332a72b) into main (4eabf77) will increase coverage by 16.67%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1444       +/-   ##
===========================================
+ Coverage   47.68%   64.35%   +16.67%     
===========================================
  Files          82       82               
  Lines        7873     7873               
===========================================
+ Hits         3754     5067     +1313     
+ Misses       3415     2159     -1256     
+ Partials      704      647       -57     
Flag Coverage Δ
e2etests 47.68% <ø> (ø)
unittests 43.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 41 files with indirect coverage changes

@AdamKorcz
Copy link
Contributor

@haydentherapper Awesome, that works fine from the OSS-Fuzz side of things as well. Thanks!

@bobcallaway bobcallaway merged commit 24cb647 into sigstore:main Apr 28, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: rekor-cli go install directions broken
5 participants