Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve fuzzing coverage for pluggable types #1499

Merged
merged 1 commit into from
May 23, 2023

Conversation

bobcallaway
Copy link
Member

@bobcallaway bobcallaway commented May 23, 2023

@AdamKorcz PTAL

Summary

Release Note

Documentation

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested review from asraa and a team as code owners May 23, 2023 16:16
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #1499 (772578c) into main (c788185) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   66.54%   66.44%   -0.10%     
==========================================
  Files          80       80              
  Lines        8022     8022              
==========================================
- Hits         5338     5330       -8     
- Misses       2034     2040       +6     
- Partials      650      652       +2     
Flag Coverage Δ
e2etests 47.83% <ø> (-0.03%) ⬇️
unittests 46.77% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@AdamKorcz AdamKorcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built this locally in OSS-Fuzz and ran a few of the fuzzers.

@bobcallaway bobcallaway merged commit d865522 into sigstore:main May 23, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants