Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap killswitch for 'docker-compose restart' #1562

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

bobcallaway
Copy link
Member

Summary

This removes the killswitch endpoint and simply calls docker-compose restart instead.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from cdris June 25, 2023 12:11
@bobcallaway bobcallaway requested a review from a team as a code owner June 25, 2023 12:11
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #1562 (4ca4082) into main (c2e3149) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
- Coverage   67.11%   67.09%   -0.02%     
==========================================
  Files          83       83              
  Lines        8407     8389      -18     
==========================================
- Hits         5642     5629      -13     
+ Misses       2090     2086       -4     
+ Partials      675      674       -1     
Flag Coverage Δ
e2etests 48.37% <ø> (-0.10%) ⬇️
unittests 47.84% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/rekor-server/app/root.go 58.94% <ø> (-0.85%) ⬇️
cmd/rekor-server/app/serve.go 85.71% <ø> (+0.90%) ⬆️

... and 1 file with indirect coverage changes

@bobcallaway bobcallaway merged commit a1349da into sigstore:main Jun 26, 2023
@github-actions github-actions bot added this to the v1.2.2 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants