Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.3.6 changelog, test IEEE P1363 sigs in DSSE #2063

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

haydentherapper
Copy link
Contributor

Summary

Release Note

Documentation

@haydentherapper haydentherapper requested a review from a team as a code owner March 29, 2024 23:30
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.93%. Comparing base (488eb97) to head (c35b193).
Report is 72 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2063       +/-   ##
===========================================
- Coverage   66.46%   48.93%   -17.53%     
===========================================
  Files          92       80       -12     
  Lines        9258     6641     -2617     
===========================================
- Hits         6153     3250     -2903     
- Misses       2359     2987      +628     
+ Partials      746      404      -342     
Flag Coverage Δ
e2etests ?
unittests 48.93% <ø> (+1.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper
Copy link
Contributor Author

haydentherapper commented Mar 29, 2024

Ideally would like to add a test for IEEE P1363 sigs too, will look at doing later. I've verified locally that it works though.

cpanato
cpanato previously approved these changes Mar 30, 2024
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper changed the title Bump sigstore/sigstore, add 1.3.6 changelog Add 1.3.6 changelog, test IEEE P1363 sigs in DSSE Apr 1, 2024
@haydentherapper
Copy link
Contributor Author

Rebased and added a test

@haydentherapper haydentherapper merged commit a678856 into sigstore:main Apr 2, 2024
14 checks passed
@haydentherapper haydentherapper deleted the bump-s-s-changelog branch April 2, 2024 04:16
@github-actions github-actions bot added this to the v1.2.2 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants