Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch minisign from homebrew instead of custom ppa #2329

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

bobcallaway
Copy link
Member

this should remove some flakiness from the builds which are failing to download minisign from the custom ubuntu ppa

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from cpanato January 13, 2025 12:50
@bobcallaway bobcallaway requested a review from a team as a code owner January 13, 2025 12:50
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.88%. Comparing base (488eb97) to head (2cf9905).
Report is 278 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2329       +/-   ##
===========================================
- Coverage   66.46%   49.88%   -16.58%     
===========================================
  Files          92      192      +100     
  Lines        9258    24683    +15425     
===========================================
+ Hits         6153    12314     +6161     
- Misses       2359    11278     +8919     
- Partials      746     1091      +345     
Flag Coverage Δ
e2etests 46.52% <ø> (-1.04%) ⬇️
unittests 41.90% <ø> (-5.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway merged commit c505919 into sigstore:main Jan 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants