Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signedEntryTimestamp signature when getting entries and client verification #333

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jun 16, 2021

Only upload (CreateLogEntry) returns a logEntryAnon that contains a signature on the (log ID, log index, body, integrated time) (the signedEntryTimestamp). We do not store the sigs on the log. Assuming that someone can/should be monitoring rekor, we mostly trust the times in the log. When retrieving the entry from rekor, we want verification rekor signed off on this entry when giving it to us, ensuring no one tweaked the timestamp between the log and the retrieval. This PR:

  • Adds a signature on any entries that are retrieved from the log.
  • Adds client verification when getting an entry by index or UUID

When cosign verifies an entry signed by short-lived cert from the TLOG, it uses the integrated time for verification. Now it can check the sig before using it sigstore/cosign#371

Testing captures this signature verification, get now requires verifyLogEntry to succeed.

Signed-off-by: Asra Ali asraa@google.com

Signed-off-by: Asra Ali <asraa@google.com>
@cpanato cpanato added this to the 0.2.0 milestone Jun 16, 2021
@dlorenc dlorenc merged commit f8449e8 into sigstore:main Jun 16, 2021
@asraa asraa deleted the add-set-signature branch June 24, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants