add signedEntryTimestamp signature when getting entries and client verification #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only upload (CreateLogEntry) returns a logEntryAnon that contains a signature on the (log ID, log index, body, integrated time) (the signedEntryTimestamp). We do not store the sigs on the log. Assuming that someone can/should be monitoring rekor, we mostly trust the times in the log. When retrieving the entry from rekor, we want verification rekor signed off on this entry when giving it to us, ensuring no one tweaked the timestamp between the log and the retrieval. This PR:
When cosign verifies an entry signed by short-lived cert from the TLOG, it uses the integrated time for verification. Now it can check the sig before using it sigstore/cosign#371
Testing captures this signature verification,
get
now requiresverifyLogEntry
to succeed.Signed-off-by: Asra Ali asraa@google.com