Switch DSSE provider to go-securesystemslib #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should note that we're planning to deprecate |
yes please do |
lukehinds
approved these changes
Sep 30, 2021
lukehinds
requested changes
Sep 30, 2021
There was a problem hiding this comment.
I think the tests need porting too:
tests/e2e_test.go:351:19: undefined: in_toto.PredicateProvenanceV01
https://github.com/sigstore/rekor/pull/442/checks?check_run_id=3742359781
1. Switch DSSE provider to go-securesystemslib 2. Update in-toto and use newly renamed SLSA provenance predicate Signed-off-by: Aditya Sirish <aditya@saky.in>
adityasaky
force-pushed
the
switch-dsse-provider
branch
from
adcb29b to
f730292
Compare
dlorenc
approved these changes
Oct 3, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya Sirish aditya@saky.in
Summary
Switches from using
github.com/in-toto/in-toto-golang/pkg/ssltogit.luolix.top/secure-systems-lab/go-securesystemslib/dsse.Ticket Link
N/A.
See: in-toto/in-toto-golang#122
Release Note