Change TreeID to be of type string instead of int64
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkatalin
approved these changes
Mar 7, 2022
bobcallaway
reviewed
Mar 7, 2022
14 tasks
When printing the TreeID with rekor-cli loginfo, if the output is parsed through jq then the TreeID gets rounded down as an int because it is bigger than JSON allows Numbers to be. This is how jq works and is mentioned in the FAQ: https://github.com/stedolan/jq/wiki/FAQ#numbers Switching this to a string will preserve the actual Tree ID. Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
priyawadhwa
force-pushed
the
tree-id-string
branch
from
0d867c1
to
0ced324
Compare
dlorenc
approved these changes
Mar 7, 2022
mattmoor
reviewed
Mar 7, 2022
| @@ -43,7 +43,7 @@ type logInfoCmdOutput struct { | |||
| TreeSize int64 | |||
| RootHash string | |||
| TimestampNanos uint64 | |||
| TreeID int64 | |||
| TreeID string | |||
There was a problem hiding this comment.
Maybe use json.Number? https://pkg.go.dev/encoding/json#Number
There was a problem hiding this comment.
Weirdly I'm still seeing the same issue with this even though it should be a string...
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing the TreeID with rekor-cli loginfo, if the output is parsed through jq
then the TreeID gets rounded down as an int because it is bigger than JSON allows Numbers to be.
This is how jq works and is mentioned in the FAQ: https://github.com/stedolan/jq/wiki/FAQ#numbers
Switching this to a string will preserve the actual Tree ID.
How this used to work:
Signed-off-by: Priya Wadhwa priya@chainguard.dev
cc @lkatalin
Summary
Ticket Link
Fixes
Release Note