Add the SHA256 digest of the intoto payload into the rekor entry #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 49.15% 48.96% -0.19%
==========================================
Files 61 61
Lines 5566 5577 +11
==========================================
- Hits 2736 2731 -5
- Misses 2536 2551 +15
- Partials 294 295 +1
Continue to review full report at Codecov.
|
haydentherapper
approved these changes
Apr 8, 2022
| if err != nil { | ||
| return nil, errors.Wrap(err, "decoding attestation") | ||
| } | ||
| attH := sha256.Sum256(decodedAttestation) |
There was a problem hiding this comment.
Should you either return an error if a non sha256 algorithm enum is specified?
There was a problem hiding this comment.
we're setting the value, its not user selectable
There was a problem hiding this comment.
Ah, looks good then!
dlorenc
approved these changes
Apr 8, 2022
|
Nice! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are storing the digest over the entire intoto envelope in the corresponding Rekor entry. This PR adds the SHA256 digest for the envelope's payload (the base64 decoded bytes) into the log entry as well.
This also fixes the length check in
Attestationto measure against the length of bytes after base64 decoding the payload, instead of the payload itself.@asraa @haydentherapper @SantiagoTorres