intoto: add index on materials digest of slsa provenance #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
bobcallaway
reviewed
Apr 26, 2022
tiziano88
previously approved these changes
Apr 26, 2022
pkg/types/intoto/v0.0.1/entry.go
Outdated
| @@ -92,6 +92,14 @@ func (v V001Entry) IndexKeys() ([]string, error) { | |||
| result = append(result, alg+":"+ds) | |||
| } | |||
| } | |||
| predicate, err := parseSlsaPredicate(v.env.Payload) | |||
There was a problem hiding this comment.
Perhaps add a comment that not all in-toto statements contain SLSA predicates, and provide some supporting links if there are?
There was a problem hiding this comment.
done! i figure we can extend this to something like "getPredicateMaterials" in case the SPDX or other predicates also include materials with digest sets.
dlorenc
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Summary
Fixes #792
Adds a key to index based on the materials of a SLSA provenance
cc @tiziano88
Ticket Link
Fixes
Release Note