Limit the number of certificates parsed in a chain #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, something in the build broke, looks unrelated to this. |
dlorenc
previously approved these changes
May 12, 2022
|
Pulling in the latest changes to sigstore/sigstore broke a few tests, because the sigstore verifiers no longer allow sha1, and alpine is using sha1. |
This closes a vector for denial of service. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
limit-chain
branch
from
45ab217
to
4418afb
Compare
Codecov Report
@@ Coverage Diff @@
## main #823 +/- ##
=======================================
Coverage 47.59% 47.60%
=======================================
Files 62 62
Lines 5503 5504 +1
=======================================
+ Hits 2619 2620 +1
Misses 2574 2574
Partials 310 310
Continue to review full report at Codecov.
|
dlorenc
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes a vector for denial of service.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note