Allow retrieving entryIDs or UUIDs via /api/v1/log/entries/retrieve endpoint
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where only 64 char UUIDs were allowed. Also adds in an integration test. Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
priyawadhwa
changed the title
/api/v1/log/entries/retrieve endpoint/api/v1/log/entries/retrieve endpoint
dlorenc
previously approved these changes
Jun 2, 2022
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
bobcallaway
reviewed
Jun 6, 2022
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
dlorenc
approved these changes
Jun 6, 2022
lkatalin
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
@priyawadhwa Looks like high level overview is this allows the 80-char entryID for searches in openapi.yaml and then in the search code itself makes sure the treeID is appropriate prepended so the search can be routed correctly?
Not sure why but my searches always worked so I didn't catch that this should also be updated. Thanks for the fix.
|
@lkatalin yup, this is specifically for the |
lkatalin
approved these changes
Jun 6, 2022
bobcallaway
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #855 where only 64 char UUIDs were allowed. Also adds in an integration test.
cc @lkatalin could you take a look at this?
Signed-off-by: Priya Wadhwa priya@chainguard.dev
Summary
Ticket Link
Fixes
Release Note