ensure fallback logic executes if attestation key is empty when fetching attestation #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 46.33% 46.29% -0.04%
==========================================
Files 60 60
Lines 5137 5137
==========================================
- Hits 2380 2378 -2
Misses 2484 2484
- Partials 273 275 +2
Continue to review full report at Codecov.
|
Signed-off-by: Bob Callaway <bcallaway@google.com>
|
I think you'll have to push to the main repo instead of a fork, and then only run this test after PR merges for auth to work correctly. |
Signed-off-by: Bob Callaway <bcallaway@google.com>
nope, i mistyped the reference to the correct container; the creds fix was a red-herring and i just removed it. |
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
|
this needs #869 to merge first but otherwise this should be ready for review |
dlorenc
approved these changes
Jun 19, 2022
dlorenc
approved these changes
Jun 20, 2022
bobcallaway
added a commit
to bobcallaway/rekor
that referenced
this pull request
Jul 6, 2022
Currently only two Rekor pluggable types support the storage of attestations (intoto, cose); the previous code to fetch attestations was type-agnostic, but due to the fix sigstore#878 the server was doing unnecessary lookups for all types, regardless of whether they store attestation content or not. This makes the attestation storage an explict interface, which we can test casting for and avoid a roundtrip to the storage layer for types that don't support storing attestations. Signed-off-by: Bob Callaway <bcallaway@google.com>
dlorenc
pushed a commit
that referenced
this pull request
Jul 6, 2022
Currently only two Rekor pluggable types support the storage of attestations (intoto, cose); the previous code to fetch attestations was type-agnostic, but due to the fix #878 the server was doing unnecessary lookups for all types, regardless of whether they store attestation content or not. This makes the attestation storage an explict interface, which we can test casting for and avoid a roundtrip to the storage layer for types that don't support storing attestations. Signed-off-by: Bob Callaway <bcallaway@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #872
Signed-off-by: Bob Callaway bcallaway@google.com