Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ldflags back #944

Merged
merged 1 commit into from
Jul 29, 2022
Merged

add ldflags back #944

merged 1 commit into from
Jul 29, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 28, 2022

Summary

I've run a v0.10.0-rc.1 and when checking the output of the version command some information were missing

$ ./rekor-cli-darwin-arm64 version
  ____    _____   _  __   ___    ____             ____   _       ___
 |  _ \  | ____| | |/ /  / _ \  |  _ \           / ___| | |     |_ _|
 | |_) | |  _|   | ' /  | | | | | |_) |  _____  | |     | |      | |
 |  _ <  | |___  | . \  | |_| | |  _ <  |_____| | |___  | |___   | |
 |_| \_\ |_____| |_|\_\  \___/  |_| \_\          \____| |_____| |___|
rekor-cli: Rekor CLI

GitVersion:    v0.10.0-rc.1
GitCommit:     unknown
GitTreeState:  unknown
BuildDate:     unknown
GoVersion:     go1.18.4
Compiler:      gc
Platform:      darwin/arm64

which sounds weird because if build locally I can see it

$ ./dist/rekor-cli-darwin-arm64 version
  ____    _____   _  __   ___    ____             ____   _       ___
 |  _ \  | ____| | |/ /  / _ \  |  _ \           / ___| | |     |_ _|
 | |_) | |  _|   | ' /  | | | | | |_) |  _____  | |     | |      | |
 |  _ <  | |___  | . \  | |_| | |  _ <  |_____| | |___  | |___   | |
 |_| \_\ |_____| |_|\_\  \___/  |_| \_\          \____| |_____| |___|
rekor-cli: Rekor CLI

GitVersion:    v0.10.0-rc.1-dirty
GitCommit:     cfa65a86e69fade0d33619bc2638b6a994f191a2
GitTreeState:  dirty
BuildDate:     2022-07-28T13:18:53
GoVersion:     go1.18.4
Compiler:      gc
Platform:      darwin/arm64

maybe the is related to the proxy that we use? not sure.
but to make sure we have the data we need I'm adding back the ldflags

Release Note

Documentation

@cpanato cpanato requested review from dlorenc and bobcallaway July 28, 2022 15:15
@cpanato cpanato requested a review from a team as a code owner July 28, 2022 15:15
Signed-off-by: cpanato <ctadeu@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #944 (53d9327) into main (cfa65a8) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   48.24%   48.35%   +0.11%     
==========================================
  Files          61       61              
  Lines        5383     5383              
==========================================
+ Hits         2597     2603       +6     
+ Misses       2504     2500       -4     
+ Partials      282      280       -2     
Impacted Files Coverage Δ
pkg/types/alpine/v0.0.1/entry.go 56.72% <0.00%> (+2.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cpanato cpanato merged commit 83a4094 into sigstore:main Jul 29, 2022
@cpanato cpanato deleted the addback branch July 29, 2022 10:11
@github-actions github-actions bot added this to the v1.0.0 milestone Jul 29, 2022
bobcallaway pushed a commit to bobcallaway/rekor that referenced this pull request Aug 3, 2022
Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants