Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist and check attestations across harness tests #952

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

priyawadhwa
Copy link
Contributor

Depends on #945 to merge first

Fixes #951

Summary

Release Note

Documentation

…versions

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
bobcallaway
bobcallaway previously approved these changes Aug 3, 2022
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa
Copy link
Contributor Author

priyawadhwa commented Aug 3, 2022

sorry @bobcallaway , could you re-approve? had to resolve a merge conflict.

@dlorenc dlorenc merged commit fedb405 into sigstore:main Aug 4, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storing expected values to validate persisence across test runs
3 participants