Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

add flag to skip certain files in the boilerplate header checker #25

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 29, 2021

made a PR in the addlicense project to skip extensions/files and that got merged (google/addlicense#75) see we can use here now :)

This PR adds the -skip flag for certain extensions/files to ignore in the boilerplate header.
for not just the extensions yml/yaml/Gemfile

also, remove the boilerplate for the other yamls files and Gemfile

do we need to add for others?

cc @bobcallaway @lukehinds

cpanato added 2 commits April 29, 2021 08:25
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Apr 29, 2021

Screenshot 2021-04-29 at 08 27 13

Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Couple of noted point, you have a wildcard at the end, will that skip files with no extension? It might be worth adding .md as well, for docs readme etc.

@bobcallaway
Copy link
Member

Nice!

Couple of noted point, you have a wildcard at the end, will that skip files with no extension? It might be worth adding .md as well, for docs readme etc.

I think the wildcard means to check all files and directories in $CWD, then applying the skip filter. LGTM

@lukehinds lukehinds merged commit 046e376 into sigstore:main Apr 30, 2021
@cpanato cpanato deleted the update-verify branch April 30, 2021 07:23
@cpanato
Copy link
Member Author

cpanato commented Apr 30, 2021

yes, the star was there in the first repo of sigstore that uses the addlicenses. this is to go over all directories and files from the root where you ran the command.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants