Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cpython artifacts #164

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Bump cpython artifacts #164

merged 2 commits into from
Nov 4, 2024

Conversation

woodruffw
Copy link
Member

Signed-off-by: William Woodruff <william@trailofbits.com>
@kommendorkapten
Copy link
Member

The change looks ok in that it references the merge commit, give me a ping when the issues with verification are sorted out 👍

@jku
Copy link
Member

jku commented Oct 17, 2024

Certificate's OIDCIssuer does not match (got 'https://github.com/login/oauth', expected 'https://accounts.google.com')

does the cpython release system allow any kind of signature or how does this happen?

@di
Copy link
Member

di commented Nov 4, 2024

does the cpython release system allow any kind of signature or how does this happen?

It allows any issuer, and this looks like it's due to sigstore/sigstore-python#1204

@woodruffw
Copy link
Member Author

Yep, that was the problem -- sorry, I forgot to follow up on this earlier. Now that that's fixed I should be able to rebuild that table and this will pass.

@di
Copy link
Member

di commented Nov 4, 2024

I think you still need woodruffw/cpython-release-tracker#8 as well, no?

@woodruffw
Copy link
Member Author

I think you still need woodruffw/cpython-release-tracker#8 as well, no?

Yep! I was going to re-run the script to pull that change in, but a manual change to it also works 🙂

action.yml Outdated Show resolved Hide resolved
Signed-off-by: William Woodruff <william@yossarian.net>
@di
Copy link
Member

di commented Nov 4, 2024

Aha, I missed that the bot pulls directly from that page 👍

@woodruffw
Copy link
Member Author

Yep! Looks like we're green again here, so CCing @kommendorkapten et al for approval 🙂

@woodruffw woodruffw merged commit d93d46c into main Nov 4, 2024
6 checks passed
@woodruffw woodruffw deleted the woodruffw-patch-1 branch November 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants