Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and documentation for signing support #203

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

steiza
Copy link
Member

@steiza steiza commented Jun 7, 2024

Summary

Closes #136 🎉 by finishing documentation, updating README, and fixing a bug uncovered while writing those things.

Release Note

  • Supports signing; see docs/signing.md and examples/sigstore-go-signing/main.go for details

Documentation

N/A - I think we want to wait for cosign support to update https://docs.sigstore.dev/signing/overview/

Also switch binaries to use Transparency interface instead of Rekor
directly.

Signed-off-by: Zach Steindler <steiza@github.com>
@steiza steiza requested a review from a team June 7, 2024 14:30
pkg/sign/signer.go Outdated Show resolved Hide resolved
Signed-off-by: Zach Steindler <steiza@github.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@steiza steiza merged commit 96c8fe6 into main Jun 10, 2024
11 checks passed
@steiza steiza deleted the readme-signing-docs branch June 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Signing
3 participants