Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation message for ProtobufBundle #271

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

codysoyland
Copy link
Member

Summary

In #251, we renamed ProtobufBundle to Bundle. This PR adds a type alias and constructor with deprecation messages so that users will know to rename their calling code to use the new type names when upgrading. Many tools and IDEs will show deprecation messages.

Example in VS Code:
image

Release Note

Documentation

Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland codysoyland requested a review from a team as a code owner August 14, 2024 18:28
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codysoyland codysoyland merged commit 81de309 into main Aug 14, 2024
11 checks passed
@codysoyland codysoyland deleted the deprecate-protobufbundle branch August 14, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants