Support Fulcio certificate "chains" that just have a root #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigstore/sigstore-conformance#112 includes confromance tests with a mock Sigstore where there are no Fulcio intermediate certificates. Signed-off-by: Zach Steindler <steiza@github.com>
haydentherapper
previously approved these changes
Dec 11, 2023
Signed-off-by: Zach Steindler <steiza@github.com>
haydentherapper
approved these changes
Dec 11, 2023
kommendorkapten
approved these changes
Dec 12, 2023
codysoyland
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were some fantastic conformance tests added with sigstore/sigstore-conformance#112.
However, one of the tests includes a mock Sigstore where Fulcio only has a root certificate and no intermediates. These changes allow that conformance test to get further (note that the conformance test won't pass with these changes, but I think that's because of an issue with the test material provided, see sigstore/sigstore-conformance#112 (comment)).
Release Note
NONE
Documentation
NA