Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional use of bouncy castle #144

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Remove conditional use of bouncy castle #144

merged 3 commits into from
Sep 12, 2022

Conversation

patflynn
Copy link
Collaborator

@patflynn patflynn commented Sep 12, 2022

TUF code requires Bouncy Castle in all jdk versions

Signed-off-by: Patrick Flynn patrick@chainguard.dev

…l jdk versions

Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
@vlsi
Copy link
Collaborator

vlsi commented Sep 12, 2022

Just wondering: can tuf be located in its own module?

E.g.:

  • tuf
  • fulcio-client
  • rekor-client
  • verifier
  • ...

Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
@patflynn
Copy link
Collaborator Author

I think it could be eventually. Currently it's very much a sigstore specific implementation.

Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
@patflynn patflynn merged commit abca981 into main Sep 12, 2022
@patflynn patflynn deleted the always-bouncy branch September 12, 2022 12:43
@patflynn
Copy link
Collaborator Author

@vlsi just to be more clear to your question. I have no objection to breaking them out as modules. I'm not in any personal rush to do it. :)

@vlsi
Copy link
Collaborator

vlsi commented Sep 12, 2022

I have no objection to breaking them out as modules. I'm not in any personal rush to do it. :)

Well, I see what you mean.

On the other hand, it might be useful to have "offline-no-dependency-verifier" module :)

@patflynn
Copy link
Collaborator Author

patflynn commented Sep 12, 2022 via email

@vlsi
Copy link
Collaborator

vlsi commented Sep 12, 2022

Oh do you mean an offline signature verification mode?

Exactly.
If I understand it right, offline signature verification can do without many third-party dependencies, and a "small" Java library might be helpful for the users to perform the verification.

@patflynn
Copy link
Collaborator Author

I guess it depends on the use-case and just how off-line we want to be. I think we want verification to not generate any rekor traffic by default, but that still requires parsing and verifying the signing bundle and tuf metadata. It'd be a really good idea to specify an offline flow but that will be a lot easier to do after the new bundle spec lands and after we've added the TUF root data to the rekor entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants