add unit testing for tuf key verification. #146
Conversation
…c verifiers factory method Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
There was a problem hiding this comment.
Just to start a discussion. I think I would just add the functional interface to Verifiers
@FunctionalInterface
public interface Supplier {
Verifier newVerifier(PublicKey publicKey) throws NoSuchAlgorithmException;
}on a method signature like
/* package private */ TufClient(Verifiers.Supplier supplier)you can inject with the method reference
new TufClient(Verifiers::newVerifier)If we don't need to expose Verifiers.Supplier we can define that functional interface in the TUF client itself.
I might also make the TUF client have one public static factory method newTufClient and have the various constructors you need for testing be package private?
Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
|
Massive improvement! Now we're cooking with gas! |
| public TufClient(Clock clock, Verifiers.Supplier verifiers) { | ||
| this.clock = clock; | ||
| this.verifiers = verifiers; | ||
| } | ||
|
|
||
| public TufClient(Verifiers.Supplier verifiers) { | ||
| this(Clock.systemUTC(), verifiers); | ||
| } |
There was a problem hiding this comment.
They can be package private and still be available for tests?
There was a problem hiding this comment.
I'll remove public. FYI the TufClient class at the moment is really just a giant place holder for the update logic. It's going to be refactored, and the current API is not reflective in any way of what the client API will be.
Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
Required refactoring static verifiers factory method. I normally have a good idea how to handle DI on the server-side, but I'm just making it up as I go here. I'm very open to changes. Eventually it might make sense to collapse the two levels of indirection between verification supplier and verification.
Work towards #60
Signed-off-by: Patrick Flynn patrick@chainguard.dev