-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @EnabledIfOidcExists instead of several Gradle test tasks #147
Conversation
f3f7f7b
to
8d11b76
Compare
A side-effect is that |
LGTM, but I would like a way to disable manual testing locally (calling to sign in) |
Run with PS https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_configuration_properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do our actions need an update?
I'm inclined to add |
So this will work because: |
-PskipOidc command-line option could be used to skip OIDC tests. skipOidc=true could be added to gradle.properties or $HOME/gradle.properties Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
Id tokens are scoped to workflow, so there appears to be reduced risk if leaked. |
Summary
The idea is to keep a single
test
task only, which would make IDE UI easier: it won't ask "which of test, testGithubOidc, testManual tasks would you like to use to execute the test".Release Note
NONE
Documentation
NONE